ZEPPELIN-3179. Improve error message when IPython is not available#2736
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
ZEPPELIN-3179. Improve error message when IPython is not available#2736zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@felixcheung @prabhjyotsingh Could you help review it ? Thanks |
felixcheung
reviewed
Jan 21, 2018
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
LG except one generic exception path
| return true; | ||
| } catch (Exception e) { | ||
| LOGGER.warn("Fail to checkIPythonPrerequisite", e); | ||
| return false; |
Member
There was a problem hiding this comment.
if there's an exception we should return a generic error string here?
| if (!freezeOutput.contains("grpcio=")) { | ||
| InterpreterContext.get().out.write("grpcio is not installed\n".getBytes()); | ||
| return false; | ||
| return "grpcio is not installed"; |
Member
There was a problem hiding this comment.
are these return strings going to trace log?
Contributor
Author
There was a problem hiding this comment.
Yes, it would be logged as well.
Contributor
Author
|
More if no more comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Minor change to improve the error message when IPython is not available. See the following screenshot.
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
verified
Screenshots (if appropriate)
Questions: