Skip to content

[ZEPPELIN-3183] Add date format support for line chart as x-axis#2739

Closed
prabhjyotsingh wants to merge 2 commits intoapache:masterfrom
prabhjyotsingh:ZEPPELIN-3183
Closed

[ZEPPELIN-3183] Add date format support for line chart as x-axis#2739
prabhjyotsingh wants to merge 2 commits intoapache:masterfrom
prabhjyotsingh:ZEPPELIN-3183

Conversation

@prabhjyotsingh
Copy link
Contributor

What is this PR for?

Add date format support for line chart as x-axis

What type of PR is it?

[Improvement]

What is the Jira issue?

Screenshots (if appropriate)

Before
before

After
after

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@zjffdu
Copy link
Contributor

zjffdu commented Jan 23, 2018

LGTM,one minor concern: is the millisecond displayed by default ? IMO, second should be sufficient for most of cases.

@prabhjyotsingh
Copy link
Contributor Author

prabhjyotsingh commented Jan 23, 2018

I think the number what you see after +{number} is the time zone. Eg:

Default which is coming from query -> 2018-01-22T14:57:43+0000
When enabled Date -> Mon Jan 22 2018 20:27:43 GMT+0530 (IST)

Update:
This is what different browser displayes:

Browser Date Format
Chrome Mon Jan 22 2018 20:27:43 GMT+0530 (IST)
Firefox 2018-01-23T03:29:59.137Z

Let me make a relevant change to make this uniform.

@prabhjyotsingh
Copy link
Contributor Author

Thanks for the review will merge this if no more discussion.

@asfgit asfgit closed this in 25d42e4 Jan 25, 2018
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-3183 branch May 2, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants