[ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)#2804
Closed
prabhjyotsingh wants to merge 6 commits intoapache:masterfrom
Closed
[ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)#2804prabhjyotsingh wants to merge 6 commits intoapache:masterfrom
prabhjyotsingh wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
Contributor
|
@prabhjyotsingh it's great that one of PMC file such PR. |
Contributor
Author
|
@mebelousov I did not follow your comment. |
Member
|
should this go to |
prabhjyotsingh
changed the title
prabhjyotsingh
force-pushed
the
discuss/eslint_semi_rule
branch
from
1387377 to
14e90bc
Compare
Member
|
@prabhjyotsingh please resolve conflicts. Otherwise LGTM. |
prabhjyotsingh
force-pushed
the
discuss/eslint_semi_rule
branch
from
14e90bc to
9a43465
Compare
Contributor
Author
|
Thanks for the review will merge this if no more discussion. |
Contributor
Author
|
Will merge this to branch-0.8 as well, so that if there are any backports they are convenient. |
Change-Id: If0356e494152c1beb8b8cef666c95d448a490749
Change-Id: If488e5a7faf68fea9c0f463de7aba1dae0607b0d
Change-Id: If9727c13bf40be52cbe40b5c7c888c99af739e9b
Change-Id: I8af5179afcd63377a4bd76486f7e30e29a97a30b
prabhjyotsingh
force-pushed
the
discuss/eslint_semi_rule
branch
from
a5c9db6 to
2d57ba3
Compare
Change-Id: I8bb3b0d81043816ce4b32de5c64859544c253ddf
Change-Id: Ibff527fdf3ab3bf91a109c56629db47e54afdcfb
asfgit
pushed a commit
that referenced
this pull request
Feb 23, 2018
Have added this PR to add a rule in eslinerc to have semicolons in javascript source [Improvement | Refactoring] * [ZEPPELIN-3245](https://issues.apache.org/jira/browse/ZEPPELIN-3245) ``` cd zeppelin-web npm install (or yarn install if you have yarn) npm run lint:once ``` Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2804 from prabhjyotsingh/discuss/eslint_semi_rule and squashes the following commits: 4506f24 [Prabhjyot Singh] eslint rule for space bc43d68 [Prabhjyot Singh] merge `[ZEPPELIN-3177]Resize charts on paragaph resize` changes 2d57ba3 [Prabhjyot Singh] fix failing WEB_E2E="true" f23cb61 [Prabhjyot Singh] remove `"linebreak-style": 0,` and `"no-use-before-define": 0,` 39f37fb [Prabhjyot Singh] remove "standard" from eslint 6edac44 [Prabhjyot Singh] add `"semi": [2, "always"]` rule in eslinerc Change-Id: I91546ea973c2c9e7540da1586d6329fc93088eb0 (cherry picked from commit ea2c944) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
jwagun
pushed a commit
to jwagun/zeppelin
that referenced
this pull request
Apr 23, 2018
Have added this PR to add a rule in eslinerc to have semicolons in javascript source [Improvement | Refactoring] * [ZEPPELIN-3245](https://issues.apache.org/jira/browse/ZEPPELIN-3245) ``` cd zeppelin-web npm install (or yarn install if you have yarn) npm run lint:once ``` Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2804 from prabhjyotsingh/discuss/eslint_semi_rule and squashes the following commits: 4506f24 [Prabhjyot Singh] eslint rule for space bc43d68 [Prabhjyot Singh] merge `[ZEPPELIN-3177]Resize charts on paragaph resize` changes 2d57ba3 [Prabhjyot Singh] fix failing WEB_E2E="true" f23cb61 [Prabhjyot Singh] remove `"linebreak-style": 0,` and `"no-use-before-define": 0,` 39f37fb [Prabhjyot Singh] remove "standard" from eslint 6edac44 [Prabhjyot Singh] add `"semi": [2, "always"]` rule in eslinerc Change-Id: I91546ea973c2c9e7540da1586d6329fc93088eb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Have added this PR to add a rule in eslinerc to have semicolons in javascript source
What type of PR is it?
[Improvement | Refactoring]
What is the Jira issue?
How should this be tested?