ZEPPELIN-3160. Fixed Checkstyle issues in kylin module#2895
Closed
HorizonNet wants to merge 2 commits intoapache:masterfrom
Closed
ZEPPELIN-3160. Fixed Checkstyle issues in kylin module#2895HorizonNet wants to merge 2 commits intoapache:masterfrom
HorizonNet wants to merge 2 commits intoapache:masterfrom
Conversation
zjffdu
reviewed
Mar 27, 2018
| "resolved": "https://registry.npmjs.org/amdefine/-/amdefine-1.0.1.tgz", | ||
| "integrity": "sha1-SlKCrBZHKek2Gbz9OtFR+BfOkfU=" | ||
| }, | ||
| "angular": { |
Member
There was a problem hiding this comment.
I think that's what he has in his setup - it's all other PRs as well
Contributor
Author
|
Reverted |
Member
|
looks good! |
jwagun
pushed a commit
to jwagun/zeppelin
that referenced
this pull request
Apr 23, 2018
### What is this PR for? Fixed the Checkstyle issues in the kylin module. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3160 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jan Hentschel <jan.hentschel@ultratendency.com> Closes apache#2895 from HorizonNet/ZEPPELIN-3160 and squashes the following commits: d01830b [Jan Hentschel] ZEPPELIN-3160. Reverted package-lock.json 455c54d [Jan Hentschel] ZEPPELIN-3160. Fixed Checkstyle issues in kylin module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixed the Checkstyle issues in the kylin module.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: