ZEPPELIN-3401. Deadlock while restarting interpreter#2937
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
ZEPPELIN-3401. Deadlock while restarting interpreter#2937zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
\cc @weand |
Member
|
IMHO, it would be better to use ReentrantReadWriteLock. What do you think of it? |
Contributor
Author
|
It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write |
1 similar comment
Contributor
Author
|
It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write |
jongyoul
approved these changes
Apr 23, 2018
Contributor
|
Today we had that bug again (seems to occur daily) without the patch added to PROD. |
Contributor
|
so far no more issues. LGTM 👍 |
Contributor
Author
|
Thanks for verifying it, @weand |
felixcheung
approved these changes
Apr 26, 2018
asfgit
pushed a commit
that referenced
this pull request
Apr 26, 2018
### What is this PR for? I suspect it is due to deadlock issue between LifecycleThread & CronJobThread: Thread | Locked | Waiting -- | -- | -- LifecycleThread | InterpreterGroup | Note CronJobThread | Note | Wait for Paragraph to finish (Paragraph can not finish because it needs the lock of InterpreterGroup This PR wold eliminate the necessary to lock on Note for LifecycleThread ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3401 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #2937 from zjffdu/ZEPPELIN-3401 and squashes the following commits: 5ffcc11 [Jeff Zhang] ZEPPELIN-3401. Deadlock while restarting interpreter (cherry picked from commit 3fb878b) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
I suspect it is due to deadlock issue between LifecycleThread & CronJobThread: Thread | Locked | Waiting -- | -- | -- LifecycleThread | InterpreterGroup | Note CronJobThread | Note | Wait for Paragraph to finish (Paragraph can not finish because it needs the lock of InterpreterGroup This PR wold eliminate the necessary to lock on Note for LifecycleThread [Bug Fix ] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-3401 * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#2937 from zjffdu/ZEPPELIN-3401 and squashes the following commits: 5ffcc11 [Jeff Zhang] ZEPPELIN-3401. Deadlock while restarting interpreter (cherry picked from commit 3fb878b) Signed-off-by: Jeff Zhang <zjffdu@apache.org> (cherry picked from commit 6ce81b5) Change-Id: I311c44cc5912d6c9d8ecaa09a8c3b614c66034e7
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? I suspect it is due to deadlock issue between LifecycleThread & CronJobThread: Thread | Locked | Waiting -- | -- | -- LifecycleThread | InterpreterGroup | Note CronJobThread | Note | Wait for Paragraph to finish (Paragraph can not finish because it needs the lock of InterpreterGroup This PR wold eliminate the necessary to lock on Note for LifecycleThread ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3401 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#2937 from zjffdu/ZEPPELIN-3401 and squashes the following commits: 5ffcc11 [Jeff Zhang] ZEPPELIN-3401. Deadlock while restarting interpreter
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? I suspect it is due to deadlock issue between LifecycleThread & CronJobThread: Thread | Locked | Waiting -- | -- | -- LifecycleThread | InterpreterGroup | Note CronJobThread | Note | Wait for Paragraph to finish (Paragraph can not finish because it needs the lock of InterpreterGroup This PR wold eliminate the necessary to lock on Note for LifecycleThread ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3401 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#2937 from zjffdu/ZEPPELIN-3401 and squashes the following commits: 5ffcc11 [Jeff Zhang] ZEPPELIN-3401. Deadlock while restarting interpreter (cherry picked from commit 3fb878b) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
I suspect it is due to deadlock issue between LifecycleThread & CronJobThread:
This PR wold eliminate the necessary to lock on Note for LifecycleThread
What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: