Skip to content

[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter#2967

Closed
sanjaydasgupta wants to merge 2 commits intoapache:masterfrom
sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery
Closed

[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter#2967
sanjaydasgupta wants to merge 2 commits intoapache:masterfrom
sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery

Conversation

@sanjaydasgupta
Copy link
Copy Markdown
Contributor

@sanjaydasgupta sanjaydasgupta commented May 14, 2018

What is this PR for?

This PR enables the interpolation of ZeppelinContext objects into the paragraph text of BigQuery cells. It also introduces a new interpreter-level configuration parameter named zeppelin.bigquery.interpolation. This new parameter is false by default, and must be set to true to enable object interpolation. The default value of false guarantees backward compatibility for users who are not aware of the new feature.

The implementation takes the same approach that was followed in PR 2898 and 2903.

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3438

How should this be tested?

Two new unit test classes have been added: BigQueryInterpolationDefaultTest.java, and BigQueryInterpolationEnabledTest.java.

Also, the code in this PR merely causes the BigQuery interpreter to "opt-in" to the implementation already existing in the Interpreter base class - described in PR-2898. The unit tests necessary are already present in PR-2898

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes, documentation changes provided in bigquery.md

@sanjaydasgupta
Copy link
Copy Markdown
Contributor Author

Need to make corrections in my repo, so am closing this PR now. Will be back with a new PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant