[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter#2967
Closed
sanjaydasgupta wants to merge 2 commits intoapache:masterfrom
sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery
Closed
[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter#2967sanjaydasgupta wants to merge 2 commits intoapache:masterfrom sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery
sanjaydasgupta wants to merge 2 commits intoapache:masterfrom
sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery
Conversation
Contributor
Author
|
Need to make corrections in my repo, so am closing this PR now. Will be back with a new PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the paragraph text of BigQuery cells. It also introduces a new interpreter-level configuration parameter named zeppelin.bigquery.interpolation. This new parameter is false by default, and must be set to true to enable object interpolation. The default value of false guarantees backward compatibility for users who are not aware of the new feature.
The implementation takes the same approach that was followed in PR 2898 and 2903.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3438
How should this be tested?
Two new unit test classes have been added: BigQueryInterpolationDefaultTest.java, and BigQueryInterpolationEnabledTest.java.
Also, the code in this PR merely causes the BigQuery interpreter to "opt-in" to the implementation already existing in the Interpreter base class - described in PR-2898. The unit tests necessary are already present in PR-2898
Screenshots (if appropriate)
Questions: