[ZEPPELIN-3491][Minor] Add apple-touch-icon.png to Zeppelin project#2981
Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-3491][Minor] Add apple-touch-icon.png to Zeppelin project#2981prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Conversation
Change-Id: Id4d15c30810402c9a815df1417448783abd93452
prabhjyotsingh
force-pushed
the
ZEPPELIN-3491
branch
from
14b8392 to
d55a73f
Compare
Member
|
LGTM |
prabhjyotsingh
commented
May 23, 2018
|
|
||
| <!-- Place favicon.ico and apple-touch-icon.png in the root directory --> | ||
| <link rel="apple-touch-icon" href="apple-touch-icon.png" /> | ||
| <link rel="icon" type="image/x-icon" href="favicon.ico" /> |
Contributor
Author
There was a problem hiding this comment.
this is done so that it picks up these icons from the relative directory, not the absolute (for example "/favicon.ico").
Contributor
Author
|
Thanks for the review will merge this soon if no more discussion. |
asfgit
pushed a commit
that referenced
this pull request
May 24, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6 (cherry picked from commit c5c1b77) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
May 24, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6
jan0sch
pushed a commit
to wegtam/zeppelin
that referenced
this pull request
May 25, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6 (cherry picked from commit c5c1b77) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
jan0sch
pushed a commit
to wegtam/zeppelin
that referenced
this pull request
May 28, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6 (cherry picked from commit c5c1b77) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
jan0sch
pushed a commit
to wegtam/zeppelin
that referenced
this pull request
May 28, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6 (cherry picked from commit c5c1b77) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6 (cherry picked from commit c5c1b77) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
This JIRA is to add apple-touch-icon.png to Zeppelin project [Minor] * [ZEPPELIN-3491](https://issues.apache.org/jira/browse/ZEPPELIN-3491) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2981 from prabhjyotsingh/ZEPPELIN-3491 and squashes the following commits: d55a73f [Prabhjyot Singh] [ZEPPELIN-3491] Add apple-touch-icon.png to Zeppelin project Change-Id: I16f8aa1cdcc0f33fcc0f728a55155ac2b1b401f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This JIRA is to add apple-touch-icon.png to Zeppelin project
What type of PR is it?
[Minor]
What is the Jira issue?
Questions: