ZEPPELIN-3352. Improve RemoteInterpreterProcess creation timeout mechanism #3021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
approved these changes
Jun 16, 2018
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…anism ### What is this PR for? This PR allow interpreter override `zeppelin.interpreter.connect.timeout` in zeppelin-site.xml. So that each interpreter can specify its own timeout threshold without restarting the zeppelin server in case he hit the timeout issue. Besides that I change the default timeout to be 60 seconds. This is what zeppelin did before. Although the default timeout is 30 seconds before, but RemoteInterpreterManagedProcess will still wait for 2 times of timeout threshold. So I directly change it to 60 secodns in this PR. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3352 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versons? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#3021 from zjffdu/ZEPPELIN-3352 and squashes the following commits: 9426d8e [Jeff Zhang] ZEPPELIN-3352. Improve RemoteInterpreterProcess creation timeout mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR allow interpreter override
zeppelin.interpreter.connect.timeoutin zeppelin-site.xml. So that each interpreter can specify its own timeout threshold without restarting the zeppelin server in case he hit the timeout issue. Besides that I change the default timeout to be 60 seconds. This is what zeppelin did before. Although the default timeout is 30 seconds before, but RemoteInterpreterManagedProcess will still wait for 2 times of timeout threshold. So I directly change it to 60 secodns in this PR.What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: