[ZEPPELIN-3733] Refactor Notebook* classes to remove circular dependencies and several listeners#3159
Closed
jongyoul wants to merge 10 commits intoapache:masterfrom
Closed
[ZEPPELIN-3733] Refactor Notebook* classes to remove circular dependencies and several listeners#3159jongyoul wants to merge 10 commits intoapache:masterfrom
Notebook* classes to remove circular dependencies and several listeners#3159jongyoul wants to merge 10 commits intoapache:masterfrom
Conversation
jongyoul
force-pushed
the
ZEPPELIN-3733
branch
3 times, most recently
from
8240027 to
ba37808
Compare
jongyoul
force-pushed
the
ZEPPELIN-3733
branch
2 times, most recently
from
ea3172c to
47e3e26
Compare
Squashed commits: [807e286] Fix tests [3b6ad26] Fix style Remove unused code [2dc0946] Fix style [7e96118] Remove unused code [472696d] Remove unused code [0ff6bdb] Change `ParagraphJobListener` from a parameter of constructor to setter Add code to enable `NotebookService` to set `ParagraphJobListener` into `Notebook` Add code to inject `NotebookServer` to `NotebookService` Add conservative logic to prepare the case where `ParagraphJobListener` is null [e97e165] Fix `NotebookServerTest` [1eccc3c] Change scopes for some bound classes [4c662c9] Add more injection code in NotebookRestApi Bind `NotebookAuthorization` and `NotebookService` Provide `getInstance()` of `ConfigurationService` and `NotebookService` to let `NotebookServer` call them
This reverts commit 2fbf4f5.
This reverts commit 3f4e2dc.
jongyoul
force-pushed
the
ZEPPELIN-3733
branch
from
331e7da to
64f4534
Compare
jongyoul
changed the title
Notebook* classes to remove circular dependencies and several listenersNotebook* classes to remove circular dependencies and several listeners
Member
Author
|
Ready to review. This PR is for refactoring only. It doesn't change any behavior at all. I'll merge if this PR passes CI correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Decoupling
Notebook*classes as they depend each others. it makes circular dependencies, and it bothers that contributors understand code.What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
CI passes
Screenshots (if appropriate)
Questions: