changed-readme-for-python-interpreter-for-apache-zeppelin#3348
Closed
d3adp007 wants to merge 2 commits intoapache:masterfrom
Closed
changed-readme-for-python-interpreter-for-apache-zeppelin#3348d3adp007 wants to merge 2 commits intoapache:masterfrom
d3adp007 wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
Thanks for the fix! LGTM |
felixcheung
reviewed
Apr 7, 2019
python/README.md
Outdated
| * [Py4J](https://www.py4j.org/) Python and Java libraries are used to load input zeppelin Java class into the python process (make java code with python code !). Therefore the interpreter can directly create Zeppelin input form inside the Python process (and eventually with some python variable already defined). JVM opens a random open port to be accessible from python process. | ||
|
|
||
| * JavaBuilder can't send SIGINT signal to interrupt paragraph execution. Therefore interpreter directly send a `kill SIGINT PID` to python process to interrupt execution. Python process catch SIGINT signal with some code defined in bootstrap.py | ||
| * JavaBuilder can't send SIGINT signal to interrupt paragraph execution. Therefore interpreter will directly send a `kill SIGINT PID` to python process to interrupt execution. Python process catches SIGINT signal with some code defined in bootstrap.py |
Member
There was a problem hiding this comment.
extra space in directly send
python/README.md
Outdated
| * Matplotlib figures are displayed inline with the notebook automatically using a built-in backend for zeppelin in conjunction with a post-execute hook. | ||
|
|
||
| * `%python.sql` support for Pandas DataFrames is optional and provided using https://github.com/yhat/pandasql if user have one installed | ||
| * `%python.sql` support for Pandas DataFrames is optional but can be downloaded from [here](https://github.com/yhat/pandasql) if user has not one installed. |
Member
There was a problem hiding this comment.
if user has not one installed. -> if user does not have one installed.
Member
|
LGTM! |
oleg-nenashev
approved these changes
Apr 9, 2019
Contributor
|
Thanks @d3adp007 ， merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixed some of the grammatical issues with the documentation for Python Interpreter for Apache Zeppelin.
What type of PR is it?
Documentation
What is the Jira issue?