Skip to content

[ZEPPELIN-4216]. Introduce ZEPPELIN_SERVER_IP to specify the ip address of thrift server#3392

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4216
Closed

[ZEPPELIN-4216]. Introduce ZEPPELIN_SERVER_IP to specify the ip address of thrift server#3392
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4216

Conversation

@zjffdu
Copy link
Copy Markdown
Contributor

@zjffdu zjffdu commented Jul 2, 2019

What is this PR for?

This PR use introduce env ZEPPELIN_SERVER_IP to specify the ip address of thrift server. It is used when you are in a complex network environment where yo might have multiple network cards or you use proxy. If it is not specified, it would still use the old approach to choose one IP randomly.

What type of PR is it?

[ Improvement ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Copy Markdown
Contributor Author

zjffdu commented Jul 2, 2019

@liuxunorg Could you help review it ? Thanks

@xunliu
Copy link
Copy Markdown
Member

xunliu commented Jul 2, 2019

findAvailableHostAddress() Especially in a container environment, Different network types may not be able to get the correct IP address.
I think this PR can solve this problem.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants