[ZEPPELIN-4219] User can start interpreter when interpreter dependencies jars are not downloaded#3398
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4219] User can start interpreter when interpreter dependencies jars are not downloaded#3398zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
2ab9949 to
1fdc97d
Compare
felixcheung
reviewed
Jul 10, 2019
Member
felixcheung
left a comment
There was a problem hiding this comment.
not using a separate thread will it block the startup as download can be slow?
Contributor
Author
|
That's right @felixcheung |
…ies jars are not downloaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Now interpreter can start even when it is downloading dependencies. It will cause ClassNotFound exception. The root cause is that the status of InterpreterSetting is incorrectly set to
READY. This PR fix this issue.What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: