Skip to content

[ZEPPELIN-4219] User can start interpreter when interpreter dependencies jars are not downloaded#3398

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4219
Closed

[ZEPPELIN-4219] User can start interpreter when interpreter dependencies jars are not downloaded#3398
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4219

Conversation

@zjffdu
Copy link
Copy Markdown
Contributor

@zjffdu zjffdu commented Jul 5, 2019

What is this PR for?

Now interpreter can start even when it is downloading dependencies. It will cause ClassNotFound exception. The root cause is that the status of InterpreterSetting is incorrectly set to READY. This PR fix this issue.

What type of PR is it?

[Bug Fix ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu zjffdu force-pushed the ZEPPELIN-4219 branch 2 times, most recently from 2ab9949 to 1fdc97d Compare July 5, 2019 15:46
Copy link
Copy Markdown
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not using a separate thread will it block the startup as download can be slow?

@zjffdu
Copy link
Copy Markdown
Contributor Author

zjffdu commented Jul 11, 2019

That's right @felixcheung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants