[ZEPPELIN-4489] remove zeppelin.anonymous.allowed configuration#3554
Closed
prabhjyotsingh wants to merge 3 commits intoapache:masterfrom
Closed
[ZEPPELIN-4489] remove zeppelin.anonymous.allowed configuration#3554prabhjyotsingh wants to merge 3 commits intoapache:masterfrom
prabhjyotsingh wants to merge 3 commits intoapache:masterfrom
Conversation
prabhjyotsingh
force-pushed
the
ZEPPELIN-4489
branch
from
a319615 to
cffee72
Compare
Contributor
|
Getting rid of |
Contributor
Author
|
Thanks for the review @zjffdu. Since this will change the way Zeppelin used to work before, where else should I change the doc? Or can that be handled at the time of release? |
Contributor
|
Thanks for reminding, we should add document here http://zeppelin.apache.org/docs/0.8.2/setup/operation/upgrading.html |
prabhjyotsingh
force-pushed
the
ZEPPELIN-4489
branch
from
f1dc7f8 to
b565386
Compare
Contributor
|
LGTM, thanks @prabhjyotsingh , let's wait for the Ci pass |
Contributor
|
CI is passed, thanks @prabhjyotsingh |
Contributor
Author
|
Sure, let me go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a proposal for removing/disabling
zeppelin.anonymous.allowedwhen Shiro is configured.My Proposal in this JIRA is; let us remove this
zeppelin.anonymous.allowed.So, when Shiro is configured then Zeppelin server runs with all the auth configured, and if the user wants anonymous access then they should not configure Shiro.ini.
What type of PR is it?
[Bug Fix | Improvement]
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: