[ZEPPELIN-4497] Change zeppelin-jupyter-adapter to zeppelin-jupyter-interpreter#3558
Closed
zjffdu wants to merge 1 commit into
Closed
[ZEPPELIN-4497] Change zeppelin-jupyter-adapter to zeppelin-jupyter-interpreter#3558zjffdu wants to merge 1 commit into
zjffdu wants to merge 1 commit into
Conversation
zjffdu
force-pushed
the
ZEPPELIN-4497
branch
3 times, most recently
from
5d7ba31 to
b8e8897
Compare
zjffdu
force-pushed
the
ZEPPELIN-4497
branch
from
b8e8897 to
2efdc1e
Compare
Contributor
Author
|
Will merge if no more comments since this is a refactoring PR, no anything new is introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In ZEPPELIN-4480, we introduce zeppelin-jupyter-adapter which build a bridge between zeppelin and jupyter, zeppelin can extends this class to leverage any kernel of jupyter.
After a second thought, I think it is not enough. We can allow user to use jupyter kernel directly instead of implement one by one. So the purpose is to allow user use jupyter kernel like this
Of course user can enhance the jupyter kernel in Zeppelin, e.g. IPythonInterpreter of Zeppelin can enhance the ipython kernel by adding support of ZeppelinContext
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: