[ZEPPELIN-4615]. Remove annoying exception when shutting down interpreter#3645
Closed
zjffdu wants to merge 1 commit into
Closed
[ZEPPELIN-4615]. Remove annoying exception when shutting down interpreter#3645zjffdu wants to merge 1 commit into
zjffdu wants to merge 1 commit into
Conversation
zjffdu
force-pushed
the
ZEPPELIN-4615
branch
from
2737723 to
ac6742e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The reason we see the annoying exception is because we call shutdown rpc in a blocking way, so before the rpc call return, the interpreter process is terminated. This PR would just wrap the shutdown in one thread in interpreter process and would return after the shutdown thread is started.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: