[ZEPPELIN-4757] Fix startup script errors/warnings#3735
Closed
alexott wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4757] Fix startup script errors/warnings#3735alexott wants to merge 1 commit intoapache:masterfrom
alexott wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi @alexott, |
Errors & warnings are produced from the checks that are assuming that Zeppelin is running on Linux (`getent` is present) & in the container environment (`/etc/passwd` is writable). This patch fixes following: - added check for presence of the `getent` - added explicit check that script is running in the container by checking `/proc/self/cgroup` - also removed `MaxPermSize` JVM flag that isn't supported in Java 8
Contributor
Author
|
@Reamer done... |
Member
|
LGTM! |
Contributor
|
LGTM |
Contributor
Author
|
Yes, I created a ZEPPELIN-4758 for it. I did here only because they were in the same shell scripts |
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2020
### What is this PR for? Errors & warnings are produced from the checks that are assuming that Zeppelin is running on Linux (`getent` is present) & in the container environment (`/etc/passwd` is writable). This patch fixes following: - added check for presence of the `getent` - added explicit check that script is running in the container by checking `/proc/self/cgroup` - also removed `MaxPermSize` JVM flag that isn't supported in Java 8 ### What type of PR is it? Bug Fix ### What is the Jira issue? * ZEPPELIN-4757 ### How should this be tested? * https://travis-ci.org/github/alexott/zeppelin/builds/675356068 Author: Alex Ott <alexott@apache.org> Closes #3735 from alexott/ZEPPELIN-4757 and squashes the following commits: ee1475a [Alex Ott] [ZEPPELIN-4757] Fix startup script errors/warnings (cherry picked from commit b877e38) Signed-off-by: Alex Ott <alexott@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Errors & warnings are produced from the checks that are assuming that Zeppelin is running
on Linux (
getentis present) & in the container environment (/etc/passwdiswritable).
This patch fixes following:
getent/proc/self/cgroupMaxPermSizeJVM flag that isn't supported in Java 8What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?