Skip to content

[ZEPPELIN-4924]. Add params to note run rest api#3827

Merged
jongyoul merged 1 commit into
apache:masterfrom
zjffdu:ZEPPELIN-4924
Jun 29, 2020
Merged

[ZEPPELIN-4924]. Add params to note run rest api#3827
jongyoul merged 1 commit into
apache:masterfrom
zjffdu:ZEPPELIN-4924

Conversation

@zjffdu
Copy link
Copy Markdown
Contributor

@zjffdu zjffdu commented Jun 28, 2020

What is this PR for?

This PR add params to note run rest api, so that user can specify params for each note run. E.g. user can specify the date to run regular ETL job.

What type of PR is it?

[Feature ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Unit test is added in NotebookRestApiTest

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? NO

Copy link
Copy Markdown
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@jongyoul jongyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jongyoul jongyoul merged commit 08451c0 into apache:master Jun 29, 2020
@jongyoul
Copy link
Copy Markdown
Member

Hello, BTW, I've used Github's merge function because I remembered it worked properly but are we still using our python script to merge some PRs?

@zjffdu
Copy link
Copy Markdown
Contributor Author

zjffdu commented Jun 29, 2020

Yes,nothing changed @jongyoul

@jongyoul
Copy link
Copy Markdown
Member

@zjffdu Got it. I'll follow it then, I've committed this PR to branch-0.9 as well by cherry-picking it.

@zjffdu
Copy link
Copy Markdown
Contributor Author

zjffdu commented Jun 29, 2020

Thanks @jongyoul for helping merge it

ps48 pushed a commit to ps48/zeppelin that referenced this pull request Jul 8, 2020
ps48 added a commit to ps48/zeppelin that referenced this pull request Jul 8, 2020
ps48 added a commit to ps48/zeppelin that referenced this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants