Skip to content

Conversation

@zhoulii
Copy link
Member

@zhoulii zhoulii commented Aug 7, 2020

What is this PR for?

solve a issue mentioned in ZEPPELIN-4988

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

Questions:

  • Does the licenses files need update? NO
  • Is there breaking changes for older versions? NO
  • Does this needs documentation? NO

@Reamer
Copy link
Contributor

Reamer commented Aug 7, 2020

Hi @zhoulii,
Thank you very much for your PR. Of course we can change the file path, this should have no side effect.
Your setup with a Zeppelin server running on a Kubernetes node is strange by the way.

@Reamer Reamer self-requested a review August 7, 2020 09:12
Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer
Copy link
Contributor

Reamer commented Aug 7, 2020

Offtopic:
Which Docker Images do you use? Help with PR #3859 would be nice.

@zhoulii
Copy link
Member Author

zhoulii commented Aug 7, 2020

Hi @Reamer , thanks for the review. The docker image we used is apache/zeppelin:0.9.0. And in my work, we just start to work with zeppelin on k8s, so it would be nice to have more opportunity to get involved in commuity, I will see what I can do for PR #3859.

@Reamer
Copy link
Contributor

Reamer commented Aug 7, 2020

If there are no further comments, I will merge the PR on Monday.

@Leemoonsoo
Copy link
Member

LGTM

@asfgit asfgit closed this in e042234 Aug 10, 2020
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Aug 14, 2020
…s is installed

### What is this PR for?
solve a issue mentioned in [ZEPPELIN-4988](https://issues.apache.org/jira/browse/ZEPPELIN-4988)

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-4988](https://issues.apache.org/jira/browse/ZEPPELIN-4988)

### How should this be tested?
* covered by the existed unit tests
* travis-ci: https://travis-ci.org/github/zhoulii/zeppelin/builds/715721363
* manually test: run zeppelin on a k8s node, the exception in [ZEPPELIN-4988](https://issues.apache.org/jira/browse/ZEPPELIN-4988) does not appear

### Questions:
* Does the licenses files need update? **NO**
* Is there breaking changes for older versions? **NO**
* Does this needs documentation? **NO**

Author: totorooo <778996335@qq.com>

Closes apache#3874 from zhoulii/run_zeppeplin_on_machine_where_k8s_is_installed and squashes the following commits:

6956fe6 [totorooo] fix bug when running zeppelin on the machine where k8s is installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants