Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Aug 11, 2020

What is this PR for?

This PR updates from aether to maven resolver.

What type of PR is it?

  • Improvement

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer Reamer changed the title [ZEPPELIN-4989] Update to Maven resolver [WIP] [ZEPPELIN-4989] Update to Maven resolver Aug 11, 2020
@Reamer Reamer changed the title [WIP] [ZEPPELIN-4989] Update to Maven resolver WIP [ZEPPELIN-4989] Update to Maven resolver Aug 11, 2020
@Reamer Reamer marked this pull request as draft August 11, 2020 07:49
@Reamer Reamer changed the title WIP [ZEPPELIN-4989] Update to Maven resolver [ZEPPELIN-4989] Update to Maven resolver Aug 11, 2020
@Leemoonsoo
Copy link
Member

@Reamer
Copy link
Contributor Author

Reamer commented Aug 12, 2020

Hi @Leemoonsoo,
I did not touch the dependency org.bouncycastle:bcpkix-jdk15on, but I can check the license.
Do we have a script to check the licenses or is everything handmade?

@Leemoonsoo
Copy link
Member

@Reamer You're right. bcprov-jdk15on-1.51 is untouched.
Unfortunately, LICENSE file is handmade.

@Reamer
Copy link
Contributor Author

Reamer commented Aug 17, 2020

Hi @Leemoonsoo
I updated the license file. Thanks for your review.

@Leemoonsoo
Copy link
Member

Thank @Reamer for working on this. The changes are looks good to me.

@Reamer
Copy link
Contributor Author

Reamer commented Aug 18, 2020

I notice a strange behaviour with the zeppelin-interpreter-shaded.jar. With this PR, org/apache/commons/logging/ is now part of the jar

To reproduce:

  • Checkout this PR
  • Run Maven mvn clean package -DskipTests -am -pl zeppelin-interpreter-shaded
  • Take a look into zeppelin-interpreter-shaded/target/zeppelin-interpreter-shaded-0.9.0-SNAPSHOT.jar
       0  Defl:N        2   0% 2020-08-18 09:53 00000000  org/apache/commons/logging/
       0  Defl:N        2   0% 2020-08-18 09:53 00000000  org/apache/commons/logging/impl/
    2063  Defl:N      628  70% 2020-08-18 09:53 9cb659ff  org/apache/commons/logging/impl/NoOpLog.class
    1097  Defl:N      589  46% 2020-08-18 09:53 33ccd884  org/apache/commons/logging/impl/SimpleLog$1.class
    9385  Defl:N     4173  56% 2020-08-18 09:53 8147c2bb  org/apache/commons/logging/impl/SimpleLog.class
    3258  Defl:N     1157  65% 2020-08-18 09:53 b06f724a  org/apache/commons/logging/impl/SLF4JLocationAwareLog.class
    2999  Defl:N     1061  65% 2020-08-18 09:53 bdd4455d  org/apache/commons/logging/impl/SLF4JLog.class
    3983  Defl:N     1829  54% 2020-08-18 09:53 43798863  org/apache/commons/logging/impl/SLF4JLogFactory.class
     479  Defl:N      263  45% 2020-08-18 09:53 38ec5139  org/apache/commons/logging/Log.class
    1298  Defl:N      664  49% 2020-08-18 09:53 d5b8f550  org/apache/commons/logging/LogConfigurationException.class
    4828  Defl:N     1792  63% 2020-08-18 09:53 c89451e3  org/apache/commons/logging/LogFactory.class

I need some help here, because I don't know why this is happening.

@Reamer Reamer force-pushed the maven_resolver branch 2 times, most recently from d3d0b11 to eede0a2 Compare September 21, 2020 09:44
@Reamer
Copy link
Contributor Author

Reamer commented Sep 21, 2020

My problem is solved after #3914. The cause is still unknown to me.

@Reamer Reamer force-pushed the maven_resolver branch 2 times, most recently from eb74ff5 to cfe268c Compare September 21, 2020 16:09
@Reamer Reamer marked this pull request as ready for review September 24, 2020 09:34
@Reamer
Copy link
Contributor Author

Reamer commented Sep 24, 2020

This PR is now ready for review.

@Reamer Reamer force-pushed the maven_resolver branch 4 times, most recently from e0a8322 to d711a47 Compare October 9, 2020 08:36
@Reamer
Copy link
Contributor Author

Reamer commented Oct 12, 2020

If there are no further comments, I will merge this PR into Master and Branch-0.9 on Wednesday (14.10.2020)

@Reamer Reamer force-pushed the maven_resolver branch 2 times, most recently from 12d49d0 to b680d72 Compare October 14, 2020 07:44
@asfgit asfgit closed this in 56ac563 Oct 14, 2020
asfgit pushed a commit that referenced this pull request Oct 14, 2020
### What is this PR for?
This PR updates from aether to maven resolver.

### What type of PR is it?
 - Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4989

### How should this be tested?
* Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/729250923

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Philipp Dallig <philipp.dallig@gmail.com>

Closes #3875 from Reamer/maven_resolver and squashes the following commits:

9b7ec55 [Philipp Dallig] Update to Maven resolver
92ff397 [Philipp Dallig] Update download plugin

(cherry picked from commit 56ac563)
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
@Reamer Reamer deleted the maven_resolver branch October 14, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants