[ZEPPELIN-5018] Small http config refactoring #3888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
force-pushed
the
small_httpConfig_cleanup
branch
from
6616a92 to
8384a65
Compare
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Aug 31, 2020
### What is this PR for? This PR includes: - Configure RequestHeaderSize directly without cast afterwards - Removing the setting of the default values, because it confuses - SecureRequestCustomizer does not need to be stored in an additional variable ### What type of PR is it? Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5018 ### How should this be tested? * **Travis-CI**: https://travis-ci.org/github/Reamer/zeppelin/builds/721255684 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes #3888 from Reamer/small_httpConfig_cleanup and squashes the following commits: 8384a65 [Philipp Dallig] SecureRequestCustomizer does not need to be stored in an additional variable 77b6ff4 [Philipp Dallig] Removing the setting of the default values, because it confuses 6b456d6 [Philipp Dallig] Configure RequestHeaderSize directly without cast (cherry picked from commit 1a41b37) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Sep 1, 2020
### What is this PR for? This PR includes: - Configure RequestHeaderSize directly without cast afterwards - Removing the setting of the default values, because it confuses - SecureRequestCustomizer does not need to be stored in an additional variable ### What type of PR is it? Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5018 ### How should this be tested? * **Travis-CI**: https://travis-ci.org/github/Reamer/zeppelin/builds/721255684 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes apache#3888 from Reamer/small_httpConfig_cleanup and squashes the following commits: 8384a65 [Philipp Dallig] SecureRequestCustomizer does not need to be stored in an additional variable 77b6ff4 [Philipp Dallig] Removing the setting of the default values, because it confuses 6b456d6 [Philipp Dallig] Configure RequestHeaderSize directly without cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR includes:
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5018
How should this be tested?
Questions: