Closed
Conversation
…ive path in the PATH environment variable can be problematic.
…s on your JVM language.
Reamer
force-pushed
the
test_refactoring
branch
from
e3c1534 to
854d366
Compare
Reamer
force-pushed
the
test_refactoring
branch
from
854d366 to
b2995a1
Compare
Contributor
Author
|
@zjffdu Ready for review |
Contributor
|
Thanks for the fix @Reamer It is really helpful and useful. Very appreciated. +1 |
Contributor
Author
|
If there are no further comments, I will merge this to Master and Branch-0.9 on Monday (07.09.2020). |
asfgit
pushed a commit
that referenced
this pull request
Sep 7, 2020
### What is this PR for? Travis-CI: - remove all environment variables from the build matrix, to use the same cache for all jobs - activate the mysql service only when this service is needed - activate the xvfb service, when is necessary and possible - removed Bower Caching to remove too many complicated lines in Travis-ci - Giving the test names - Installing R only once with conda, previously it was installed twice with 'testing/install_R.sh' and 'testing/install_external_dependencies.sh - remove the R-Cache, because the installation with conda is quite fast - Delete 'test/install_R.sh' because it is no longer used Other: - Ignore the tests in 'HeliumApplicationFactoryTest.java' to get the JUnit tests running in the IDE + remove exclude in 'travis.yml - Remove deprecation warning in maven-surefire-plugin - Helium works better with an absolute path, because a relative path in PATH, is not a good idea for local testing - Remove JVM language dependent asserts ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5024 ### How should this be tested? * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/723116251 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes #3897 from Reamer/test_refactoring and squashes the following commits: 5f0dc19 [Philipp Dallig] Remove zeppelin artifacts from m2 cache e44957d [Philipp Dallig] Remove old install_R.sh cb0ee7f [Philipp Dallig] Install R with conda, because then we need no sudo rights b57906b [Philipp Dallig] Remove Spark distribution from cache, because the version is differs between tests b2995a1 [Philipp Dallig] Give specific jobs an unique cache 837ff9d [Philipp Dallig] Remove env in each job to use the same cache 4153765 [Philipp Dallig] Remove bower_components cache 7ae02b1 [Philipp Dallig] Only run mysql, if we need mysql for integration tests d70e201 [Philipp Dallig] Use service for xvfb - display tests e0a6ba3 [Philipp Dallig] Naming build jobs ab1694e [Philipp Dallig] forkMode is deprecated, migrate to new properties f0fe751 [Philipp Dallig] The String "command not found" and "No such file or directory" depends on your JVM language. c0b8071 [Philipp Dallig] Disable HeliumApplicationFactoryTest in SourceCode 2b13a0e [Philipp Dallig] The maven-frontend-plugin works better with an absolute path. A relative path in the PATH environment variable can be problematic. (cherry picked from commit 3b994f3) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Travis-CI:
Other:
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Questions: