[ZEPPELIN-5044] Refactoring some viewed classes#3909
Closed
Reamer wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-5044] Refactoring some viewed classes#3909Reamer wants to merge 1 commit intoapache:masterfrom
Reamer wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I will merge this on Thursday into master and branch-0.9, if there are no further comments. |
Contributor
|
LGTM |
Contributor
|
@Reamer The jira is not correct: ZEPPELIN-4612 |
Contributor
Author
Thanks, I have corrected to the correct Jira ticket. ZEPPELIN-5044 |
Reamer
changed the title
asfgit
pushed a commit
that referenced
this pull request
Sep 17, 2020
### What is this PR for?
During development, I came across code that did not conform to current best practices.
For example:
- Logging
- [Anti-Pattern-1](https://rolf-engelhard.de/2013/03/logging-anti-patterns-part-i/), [Anti-Pattern-2](https://rolf-engelhard.de/2013/04/logging-anti-patterns-part-ii/), [Anti-Pattern-3](https://rolf-engelhard.de/2013/10/logging-anti-patterns-part-iii/)
- [try-with-resources](https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html)
### What type of PR is it?
Refactoring
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5044
### How should this be tested?
* Travis CI: https://travis-ci.org/github/Reamer/zeppelin/builds/727295209
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Philipp Dallig <philipp.dallig@gmail.com>
Closes #3909 from Reamer/refactoring and squashes the following commits:
dcf0417 [Philipp Dallig] Refactoring some viewed classes
(cherry picked from commit fbea3e0)
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
During development, I came across code that did not conform to current best practices.
For example:
What type of PR is it?
Refactoring
What is the Jira issue?
How should this be tested?
Questions: