[ZEPPELIN-5068] Angular username and password encoding#3923
Closed
Reamer wants to merge 2 commits intoapache:masterfrom
Closed
[ZEPPELIN-5068] Angular username and password encoding#3923Reamer wants to merge 2 commits intoapache:masterfrom
Reamer wants to merge 2 commits intoapache:masterfrom
Conversation
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2020
### What is this PR for? This PR encodes username and password. `Content-Type: application/x-www-form-urlencoded` is set automatically. I also found a small typo and corrected the spelling of Notebook. ### What type of PR is it? - Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5068 ### How should this be tested? * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/729873263 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes #3923 from Reamer/angular_username_and_password_encoding and squashes the following commits: 1ac7170 [Philipp Dallig] Correct spelling for Notebook dd2f019 [Philipp Dallig] Encode username and password (cherry picked from commit 2e69f71) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR encodes username and password.
Content-Type: application/x-www-form-urlencodedis set automatically.I also found a small typo and corrected the spelling of Notebook.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Questions: