[ZEPPELIN-5109]. Support knox in zeppelin-client#3955
Closed
zjffdu wants to merge 2 commits intoapache:masterfrom
Closed
[ZEPPELIN-5109]. Support knox in zeppelin-client#3955zjffdu wants to merge 2 commits intoapache:masterfrom
zjffdu wants to merge 2 commits intoapache:masterfrom
Conversation
zjffdu
force-pushed
the
ZEPPELIN-5109
branch
6 times, most recently
from
4ae5582 to
3c4c95e
Compare
Contributor
|
Maybe it makes sense to split the PR into GSON update and knox support for Zeppelin client. |
Contributor
Author
|
@Reamer gson upgrade is necessary to support knox. Let me create a PR for gson first. |
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Nov 7, 2020
### What is this PR for? This PR add support of knox in zeppelin-client. I tested it in a real environment. What user need to provide is the knos sso url ### What type of PR is it? [ Feature ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5109 ### How should this be tested? * CI Pass. https://travis-ci.com/github/zjffdu/zeppelin/builds/196564937 Sample code ``` ClientConfig clientConfig = new ClientConfig("https://xxx:8443/gateway/cluster-topo/zeppelin", 1000, "https://xxx:8443/gateway/knoxsso/api/v1/websso"); ZeppelinClient zeppelinClient = new ZeppelinClient(clientConfig); zeppelinClient.login("username", "password"); String version = zeppelinClient.getVersion(); System.out.println(version); ``` ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3955 from zjffdu/ZEPPELIN-5109 and squashes the following commits: 76ada3d [Jeff Zhang] update gson in S3NotebookRepo 8ca5770 [Jeff Zhang] [ZEPPELIN-5109]. Support knox in zeppelin-client (cherry picked from commit 17d2cab) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR add support of knox in zeppelin-client. I tested it in a real environment. What user need to provide is the knos sso url
What type of PR is it?
[ Feature ]
Todos
What is the Jira issue?
How should this be tested?
https://travis-ci.com/github/zjffdu/zeppelin/builds/196564937
Sample code
Screenshots (if appropriate)
Questions: