[ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@zjffdu |
Contributor
Author
|
Oops, my fault, let me fix it. |
…e version when there's empty line ahead" This reverts commit 3644538.
Contributor
Author
|
Will merge will if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2021
### What is this PR for? The root cause is that we didn't reload the notes from NotebookRepo. It is a straightforwrad fix with only 1 line code change. ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5162 ### How should this be tested? * Manually tested. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3997 from zjffdu/ZEPPELIN-5162 and squashes the following commits: 4aa5131 [Jeff Zhang] Revert "[ZEPPELIN-5169]. Hive set statement doesn't work for some hive version when there's empty line ahead" 3644538 [Jeff Zhang] [ZEPPELIN-5169]. Hive set statement doesn't work for some hive version when there's empty line ahead f812548 [Jeff Zhang] [ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work (cherry picked from commit d0928ea) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The root cause is that we didn't reload the notes from NotebookRepo. It is a straightforwrad fix with only 1 line code change.
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: