Skip to content

[ZEPPELIN-5204]. NPE when runAsOne is true in flink interpreter#4039

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-5204
Closed

[ZEPPELIN-5204]. NPE when runAsOne is true in flink interpreter#4039
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-5204

Conversation

@zjffdu
Copy link
Copy Markdown
Contributor

@zjffdu zjffdu commented Jan 31, 2021

What is this PR for?

This PR is to fix the NPE when runAsOne is true in flink interpreter. The root cause is that runAsOne should only take effect when there's at least one insert statement.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Test is added

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu zjffdu force-pushed the ZEPPELIN-5204 branch 2 times, most recently from 3ffe44c to e0ac055 Compare February 2, 2021 04:46
@zjffdu
Copy link
Copy Markdown
Contributor Author

zjffdu commented Feb 5, 2021

Will merge if no more comment

@asfgit asfgit closed this in c063eba Feb 5, 2021
asfgit pushed a commit that referenced this pull request Feb 5, 2021
### What is this PR for?

This PR is to fix the NPE when `runAsOne` is true in flink interpreter. The root cause is that runAsOne should only take effect when there's at least one insert statement.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5204

### How should this be tested?
* Test is added

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #4039 from zjffdu/ZEPPELIN-5204 and squashes the following commits:

3138cf5 [Jeff Zhang] [ZEPPELIN-5204]. NPE when runAsOne is true in flink interpreter

(cherry picked from commit c063eba)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant