[ZEPPELIN-5242] Change **/interpreter/** to interpreter/**#4049
Closed
Reamer wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-5242] Change **/interpreter/** to interpreter/**#4049Reamer wants to merge 1 commit intoapache:masterfrom
Reamer wants to merge 1 commit intoapache:masterfrom
Conversation
Reamer
force-pushed
the
rat_correction
branch
from
d9de32d to
85e32c5
Compare
Contributor
Author
|
@zjffdu Any thoughts on this amended exclusion rule? |
Contributor
|
LGTM |
Contributor
Author
|
I will merge this PR into master and branch-0.9 on Wednesday (10/02/2021) if no further comments are received. |
asfgit
pushed a commit
that referenced
this pull request
Feb 10, 2021
### What is this PR for? This PR corrects the rat exclusion `**/interpreter/**` which is too wide. I think we should only exclude the interpreter folder from the root path. ### What type of PR is it? - Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5242 ### How should this be tested? * CI ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes #4049 from Reamer/rat_correction and squashes the following commits: 85e32c5 [Philipp Dallig] Change **/interpreter/** to interpreter/** (cherry picked from commit 913ed3c) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR corrects the rat exclusion
**/interpreter/**which is too wide. I think we should only exclude the interpreter folder from the root path.What type of PR is it?
What is the Jira issue?
How should this be tested?
Questions: