Skip to content

[ZEPPELIN-5229] - bump flink 1.10 minor version#4052

Closed
omrisk wants to merge 3 commits intoapache:masterfrom
omrisk:ZEPPELIN-5229-upgrade-flink-version
Closed

[ZEPPELIN-5229] - bump flink 1.10 minor version#4052
omrisk wants to merge 3 commits intoapache:masterfrom
omrisk:ZEPPELIN-5229-upgrade-flink-version

Conversation

@omrisk
Copy link
Contributor

@omrisk omrisk commented Feb 11, 2021

What is this PR for?

Bumping flink minor version, fixing minor flink doc typos

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5229

How should this be tested?

Automation and builds

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? - no
  • Is there breaking changes for older versions? - no
  • Does this needs documentation? - no

@zjffdu
Copy link
Contributor

zjffdu commented Feb 11, 2021

@omrisk
Copy link
Contributor Author

omrisk commented Feb 11, 2021

@zjffdu, thanks, missed that, fixed.
Newbie question, should parameters like that be extracted to a .properties file (in a seperate issue/PR)?
So that versions can be fully managed for builds in tests with a single source for the values?

@zjffdu
Copy link
Contributor

zjffdu commented Feb 11, 2021

That's would be better, @omrisk maybe put them in project root pom.xml.
If that is possible, we should do the same thing for spark as well.

@omrisk
Copy link
Contributor Author

omrisk commented Feb 11, 2021

@zjffdu , opened this separate ticket for that https://issues.apache.org/jira/browse/ZEPPELIN-5247.
I'll try to handle soon in a separate PR

@zjffdu
Copy link
Contributor

zjffdu commented Feb 16, 2021

LGTM, will merge if no more comment.

@asfgit asfgit closed this in 4a25272 Feb 17, 2021
asfgit pushed a commit that referenced this pull request Feb 17, 2021
### What is this PR for?
Bumping flink minor version, fixing minor flink doc typos

### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5229

### How should this be tested?
Automation and builds

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? - no
* Is there breaking changes for older versions? - no
* Does this needs documentation? - no

Author: OmriK <omri.keefe@dynamicyield.com>

Closes #4052 from omrisk/ZEPPELIN-5229-upgrade-flink-version and squashes the following commits:

7e88381 [OmriK] bump flink 1.10 minor version in integration tests
d86c374 [OmriK] Minor readme fixes for flink docs
8bc7d7a [OmriK] bump flink 1.10 minor version

(cherry picked from commit 4a25272)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants