[ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions#4054
[ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions#4054omrisk wants to merge 2 commits intoapache:masterfrom
Conversation
|
Thank @omrisk for the contribution! I tested this on
as well as with the latest Docker engine @omrisk Looks like rat plugin fails due to missing license header on docker-compose.yml file. Could you try to add a license header? (e.g. https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml#L1-L16) |
|
I think docker-compose is unnecessary as we only have one container. |
|
@Reamer , I though the |
I think this is bearable as long as you don't have to restart the container for every change in the docs. |
|
@Reamer , ok. The command I added mounts the |
|
LGTM |
|
LGTM, I tested it and it works very well |
… instructions ### What is this PR for? To make it easier for new contributors to build and test documentation changes, will add support to build and serve locally using docker. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5248 ### How should this be tested? * Automated CI * Can be tested by following updated README instructions to run `docker-compose up` locally * ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: OmriK <omri.keefe@dynamicyield.com> Closes #4054 from omrisk/ZEPPELIN-5248-docker-support-for-local-documentation and squashes the following commits: cbb9061 [OmriK] Convert to single command docker run, remove docker-compose.yml d4cf003 [OmriK] Add local docker-compose support and updated readme instructions (cherry picked from commit 9259620) Signed-off-by: Jeff Zhang <zjffdu@apache.org>


What is this PR for?
To make it easier for new contributors to build and test documentation changes, will add support to build and serve locally using docker.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5248
How should this be tested?
docker-compose uplocallyScreenshots (if appropriate)
Questions: