[ZEPPELIN-5257] Refactoring of ExecutionContext#4058
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-5257] Refactoring of ExecutionContext#4058zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
zjffdu
force-pushed
the
ZEPPELIN-5257
branch
2 times, most recently
from
c46af55 to
5535e2d
Compare
Contributor
|
In general, I like the builder pattern for I see that you are changing attributes of the |
Contributor
Author
|
@Reamer The reason of moving |
zjffdu
force-pushed
the
ZEPPELIN-5257
branch
from
5535e2d to
a48926f
Compare
Contributor
Author
|
Will merge if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2021
### What is this PR for? This PR is to refactoring ExecutionContext: move its creation to `Note`, because most of fields of ExecutionContext is from Note. Moving it to `Note` (Note#getExecutionContext) can help us to create consistent object (avoid missing fields) ### What type of PR is it? [Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5257 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #4058 from zjffdu/ZEPPELIN-5257 and squashes the following commits: 84768c1 [Jeff Zhang] [ZEPPELIN-5257] Refactoring of ExecutionContext (cherry picked from commit 85ed8e2) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is to refactoring ExecutionContext: move its creation to
Note, because most of fields of ExecutionContext is from Note. Moving it toNote(Note#getExecutionContext) can help us to create consistent object (avoid missing fields)What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: