[ZEPPELIN-5299] Comment at end of query causes query to be ignored#4081
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-5299] Comment at end of query causes query to be ignored#4081zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Will merge if no more comment |
zjffdu
changed the title
asfgit
pushed a commit
that referenced
this pull request
Apr 7, 2021
### What is this PR for? This is to fix the corner case that when the comment is at the end of query, the query will be skipped due to bug in SqlSplitter. This PR fix the bug in SqlSplitter and also add UT ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5299 ### How should this be tested? * UT is added ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #4081 from zjffdu/ZEPPELIN-5299 and squashes the following commits: 8a376b9 [Jeff Zhang] [ZEPPELIN-5299] Comment at end of query causes query to be ignored (cherry picked from commit e0e2ca5) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is to fix the corner case that when the comment is at the end of query, the query will be skipped due to bug in SqlSplitter.
This PR fix the bug in SqlSplitter and also add UT
What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: