[ZEPPELIN-5472] Disable dynamic form for shell interpreter by default#4218
Closed
zjffdu wants to merge 1 commit into
Closed
[ZEPPELIN-5472] Disable dynamic form for shell interpreter by default#4218zjffdu wants to merge 1 commit into
zjffdu wants to merge 1 commit into
Conversation
zjffdu
force-pushed
the
ZEPPELIN-5472
branch
2 times, most recently
from
f695a85 to
7ea7544
Compare
Contributor
Author
|
Will merge if no more comment |
zjffdu
force-pushed
the
ZEPPELIN-5472
branch
from
7ea7544 to
d4f17fb
Compare
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for?
This PR change the form type of shell interpreter from SIMPLE to NATIVE, so that ${var} won't be translated into dynamic form. Because ${var} is often used as variable reference, so we should not confuse user in Zeppelin. If user do want to use dynamic form, they can still use local property to override that. e.g.
```
%sh(form=simple)
echo ${name}
```
### What type of PR is it?
[ Improvement ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5472
### How should this be tested?
* Unit test is added.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zjffdu@apache.org>
Closes apache#4218 from zjffdu/ZEPPELIN-5472 and squashes the following commits:
d4f17fb [Jeff Zhang] [ZEPPELIN-5472] Disable dynamic form for shell interpreter by default
zlosim
pushed a commit
to zlosim/zeppelin
that referenced
this pull request
Oct 22, 2021
### What is this PR for?
This PR change the form type of shell interpreter from SIMPLE to NATIVE, so that ${var} won't be translated into dynamic form. Because ${var} is often used as variable reference, so we should not confuse user in Zeppelin. If user do want to use dynamic form, they can still use local property to override that. e.g.
```
%sh(form=simple)
echo ${name}
```
### What type of PR is it?
[ Improvement ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5472
### How should this be tested?
* Unit test is added.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zjffdu@apache.org>
Closes apache#4218 from zjffdu/ZEPPELIN-5472 and squashes the following commits:
d4f17fb [Jeff Zhang] [ZEPPELIN-5472] Disable dynamic form for shell interpreter by default
JasonLeeCoding
pushed a commit
to JasonLeeCoding/zeppelin
that referenced
this pull request
Jan 5, 2022
### What is this PR for?
This PR change the form type of shell interpreter from SIMPLE to NATIVE, so that ${var} won't be translated into dynamic form. Because ${var} is often used as variable reference, so we should not confuse user in Zeppelin. If user do want to use dynamic form, they can still use local property to override that. e.g.
```
%sh(form=simple)
echo ${name}
```
### What type of PR is it?
[ Improvement ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5472
### How should this be tested?
* Unit test is added.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zjffdu@apache.org>
Closes apache#4218 from zjffdu/ZEPPELIN-5472 and squashes the following commits:
d4f17fb [Jeff Zhang] [ZEPPELIN-5472] Disable dynamic form for shell interpreter by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR change the form type of shell interpreter from SIMPLE to NATIVE, so that ${var} won't be translated into dynamic form. Because ${var} is often used as variable reference, so we should not confuse user in Zeppelin. If user do want to use dynamic form, they can still use local property to override that. e.g.
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: