[ZEPPELIN-5942] Adds a null check to recoveryStorage #4681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What is this PR for? Fix NullPointerException of org.apache.zeppelin.socket.NotebookServer when invalid ticket message received This exception may occur when server sessions is not contains received principal. In other words, it happend when no session case. ### What type of PR is it? Bug Fix ### Todos haven't ### What is the Jira issue? [ZEPPELIN-5468] Fix NullPointerException of org.apache.zeppelin.socket.NotebookServer when invalid ticket message received ### How should this be tested? Login visit page and then logout in other page, see log output ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: vmaster <vmaster.cc@gmail.com> Closes apache#4186 from aib628/branch-0.9-bugfix and squashes the following commits: 026c1f8 [vmaster] [bugfix]Fast return when invalid ticket of no session case (cherry picked from commit 831dc50) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit 114a06f)
### What is this PR for? This PR just update the python to reflect the latest feature and remove some outdated content. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5480 * ### How should this be tested? * No ci needed ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4201 from zjffdu/ZEPPELIN-5480 and squashes the following commits: 77933fe [Jeff Zhang] [ZEPPELIN-5480] Update python doc (cherry picked from commit e94790b)
### What is this PR for? Add more content for flink interpreter. ### What type of PR is it? [Documentation ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5484 ### How should this be tested? * No test needed ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4202 from zjffdu/ZEPPELIN-5484 and squashes the following commits: 41beb1b [Jeff Zhang] [ZEPPELIN-5484] Update flink doc (cherry picked from commit 3b5d4c2)
(cherry picked from commit d4d82e3)
… null ### What is this PR for? This PR fixes a NullPointerException if the InterpreterResult is `null`. ### What type of PR is it? Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5489 ### How should this be tested? * via CI ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <philipp.dallig@gmail.com> Closes apache#4205 from Reamer/ApiNullPointer and squashes the following commits: 550f7a4 [Philipp Dallig] Fix NullPointerException, if the InterpreterResult is null (cherry picked from commit d896163)
### What is this PR for? * Update spark doc * Other docs like install.md are updated in this PR as well * Add one new tutorial note for how to run pyspark with customized python runtime in yarn ### What type of PR is it? [Documentation ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5483 ### How should this be tested? * no tests needed ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jeff Zhang <zjffdu@apache.org> Closes apache#4203 from zjffdu/ZEPPELIN-5483 and squashes the following commits: 42b6213 [Jeff Zhang] [ZEPPELIN-5483] Update spark doc (cherry picked from commit 2276573)
…overy.storage.class is not org.apache.zeppelin.interpreter.recovery.NullRecoveryStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds a null to the argument
recoveryStoragein the constructor ofInterpreterLauncher. Specifically, if the argument is null whenzeppelin.recovery.storage.classis notorg.apache.zeppelin.interpreter.recovery.NullRecoveryStorage, anIllegalArgumentExceptionwill be thrown.What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
(1) Set
zeppelin.recovery.storage.classtoorg.apache.zeppelin.interpreter.recovery.FileSystemRecoveryStorage(2) Run test:
org.apache.zeppelin.interpreter.launcher.StandardInterpreterLauncherTest#testLauncherThe test will lead to an
IllegalArgumentException, instead of aNullPointerExceptionwithout any message.Questions: