Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 30, 2024

What is this PR for?

The existing Python-based dev/test_zeppelin_pr.py seems complex and has been broken. I replace it with a simple shell script.

What type of PR is it?

This fixes a dev tool.

Todos

N/A

What is the Jira issue?

ZEPPELIN-6070

How should this be tested?

Tested manually.

$ apache-zeppelin git:(ZEPPELIN-6070) dev/checkout_zeppelin_pr.sh 4802
+ APACHE_ZEPPELIN_REMOTE_REPO_NAME=apache
+ [[ 1 -eq 0 ]]
+ FORCE=
+ getopts :f arg
+ shift 0
+ PR_NUM=4802
+ git fetch apache pull/4802/head:PR_4802
remote: Enumerating objects: 305, done.
remote: Counting objects: 100% (305/305), done.
remote: Compressing objects: 100% (123/123), done.
remote: Total 305 (delta 131), reused 293 (delta 130), pack-reused 0 (from 0)
Receiving objects: 100% (305/305), 74.27 KiB | 200.00 KiB/s, done.
Resolving deltas: 100% (131/131), completed with 37 local objects.
From github.com:apache/zeppelin
 * [new ref]             refs/pull/4802/head -> PR_4802
+ git checkout PR_4802
Switched to branch 'PR_4802'
$ apache-zeppelin git:(PR_4802) 

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

Copy link
Contributor

@tbonelee tbonelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected and LGTM

@pan3793 pan3793 merged commit 22bfdc7 into apache:master Sep 1, 2024
@pan3793
Copy link
Member Author

pan3793 commented Sep 1, 2024

Thanks, merged to master

@pan3793 pan3793 deleted the ZEPPELIN-6070 branch September 20, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants