[ZEPPELIN-6096] Cursor appears cut off in Notebook editor #4873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Oct 16, 2024
pan3793
pushed a commit
that referenced
this pull request
Oct 16, 2024
### What is this PR for? https://github.com/user-attachments/assets/6204b6f5-409e-4cd1-8901-eb09114e9ded Steps to reproduce: 1. Make a new Paragraph. 2. Refresh the page. 3. Click on the paragraph to make the cursor blink. [How to solve] https://github.com/apache/zeppelin/blob/bdf5b067b6bdde2614b98a6a3f6a7b5d6637e57c/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts#L62 Set default value of editor's height ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? * [[ZEPPELIN-6096](https://issues.apache.org/jira/browse/ZEPPELIN-6096)] ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? N * Is there breaking changes for older versions? N * Does this needs documentation? N Closes #4873 from dididy/fix/ZEPPELIN-6096. Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit cd31c31) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
Thanks, merged to master/0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Screen_Recording_2024-09-08_at_23.44.12.mov
Steps to reproduce:
[How to solve]
zeppelin/zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts
Line 62 in bdf5b06
Set default value of editor's height
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: