Skip to content

Conversation

@tbonelee
Copy link
Contributor

@tbonelee tbonelee commented Sep 7, 2025

What is this PR for?

Windows cmd and does not support wildcard path expansion, which causes errors like the one below.
image

This PR fixes the issue by replacing the glob pattern path argument with a specific tsconfig.json file for tslint-rules/.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6319

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@ParkGyeongTae ParkGyeongTae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving the issue that stemmed from the changes I made. 👍👍

@ParkGyeongTae ParkGyeongTae merged commit c9d6b13 into apache:master Sep 9, 2025
16 of 18 checks passed
ParkGyeongTae pushed a commit that referenced this pull request Sep 9, 2025
…n-web-angular

### What is this PR for?
Windows cmd and does not support wildcard path expansion, which causes errors like the one below.
<img width="954" height="190" alt="image" src="https://github.com/user-attachments/assets/3356609d-d2a6-4135-8c35-75d35df54291" />

This PR fixes the issue by replacing the glob pattern path argument with a specific `tsconfig.json` file for `tslint-rules/`.



### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6319

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes #5070 from tbonelee/fix-wildcard-path.

Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>
@ParkGyeongTae
Copy link
Member

Merged into master and branch-0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants