ZOOKEEPER-1636: cleanup completion list of a failed multi request #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
anmolnar
approved these changes
Jul 31, 2019
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
+1 lgtm
We're not backporting patches automatically to 3.4 anymore. Only security and critical bug fixes allowed.
I think this one is good to go. Thanks!
| const int nops = iteration * type_count; | ||
| char buff[1024]; | ||
|
|
||
| zoo_op_result_t results[nops]; |
Contributor
There was a problem hiding this comment.
There're some indentation mistakes in this test. Please fix them.
Contributor
Author
There was a problem hiding this comment.
done!
// thank you for this catch!
Contributor
Author
hanm
approved these changes
Aug 1, 2019
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2019
This is a backport of #717 to `branch-3.4` For some reason it was NOT merged to `branch-3.4`, but only to `branch-3.5` and `master`: - 4bd32be - b1fd480 Here, it's almost a cherry-pick of the original patch, but slightly adopted to specific of `branch-3.4`. Namely, `cleanup_failed_multi()` and `deserialize_multi()` do not have the first parameter `zhandle_t *zh`. ---- I wish to backport this also to use it as the base for my #999 Author: Alexander A. Strelets <streletsaa@gmail.com> Reviewers: Andor Molnár <andor@apache.org>, Michael Han <hanm@apache.org> Closes #1030 from xoiss/ZOOKEEPER-1636
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #717 to
branch-3.4For some reason it was NOT merged to
branch-3.4, but only tobranch-3.5andmaster:Here, it's almost a cherry-pick of the original patch, but slightly adopted to specific of
branch-3.4.Namely,
cleanup_failed_multi()anddeserialize_multi()do not have the first parameterzhandle_t *zh.I wish to backport this also to use it as the base for my #999