Skip to content

ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time#1033

Closed
Lagrang wants to merge 21 commits intoapache:masterfrom
Lagrang:ZOOKEEPER-3320
Closed

ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time#1033
Lagrang wants to merge 21 commits intoapache:masterfrom
Lagrang:ZOOKEEPER-3320

Conversation

@Lagrang
Copy link
Copy Markdown
Contributor

@Lagrang Lagrang commented Aug 2, 2019

Improvements and fixes of #863

Igor Skokov and others added 20 commits July 11, 2019 08:49
…read, add test to CnxManagerTest to check configurable retries of leader election port bind
…ger.Listener fails to bind to election port
… infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
…read, add test to CnxManagerTest to check configurable retries of leader election port bind
…ger.Listener fails to bind to election port
… infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
…3320

# Conflicts:
#	zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/CnxManagerTest.java
@Lagrang
Copy link
Copy Markdown
Contributor Author

Lagrang commented Aug 2, 2019

@anmolnar @nkalmar This is new PR with changes proposed in #863.

Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Just a nitpick.

keepalive for more information. Defaults to
**false**.

* *zookeeper.electionPortBindRetry* :
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to electionPortBindRetry

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lagrang for the fix, +1 !

@Lagrang
Copy link
Copy Markdown
Contributor Author

Lagrang commented Aug 5, 2019

@anmolnar @nkalmar Thanks for support! Will wait merge:)

@asfgit asfgit closed this in 6692d7a Aug 6, 2019
@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Aug 6, 2019

Merged to master branch. Thanks @Lagrang !
Would you please create separate PR for branch-3.5?
It would be nice to backport the fix.

@Lagrang
Copy link
Copy Markdown
Contributor Author

Lagrang commented Aug 6, 2019

@anmolnar ok, I will prepare PR in next few days(I hope:))

asfgit pushed a commit that referenced this pull request Aug 13, 2019
…sten when hostname unresolvable for some time

Backport of #1033 to branch-3.5

Author: Igor Skokov <igor.skokov@cinarra.com>

Reviewers: eolivelli@apache.org, andor@apache.org

Closes #1053 from Lagrang/ZOOKEEPER-3320-BACKPORT35
@Lagrang Lagrang deleted the ZOOKEEPER-3320 branch August 24, 2019 12:52
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
…lvable for some time

Improvements and fixes of apache#863

Author: Igor Skokov <igor.skokov@cinarra.com>
Author: Igor Skokov <lagrang09@gmail.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#1033 from Lagrang/ZOOKEEPER-3320 and squashes the following commits:

50d6465 [Igor Skokov] ZOOKEEPER-3320: doc fix, rename config property 'zookeeper.electionPortBindRetry' to 'electionPortBindRetry'
fb9cdc5 [Igor Skokov] Merge remote-tracking branch 'lagrang/ZOOKEEPER-3320' into ZOOKEEPER-3320
f95ee18 [Igor Skokov] ZOOKEEPER-3320: CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry fix
1af098d [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
7b222ef [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
5051b4c [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
eeb5c41 [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
587fd95 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
0888a29 [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
a9a9342 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
da33c1d [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
e25b445 [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
b4abdc7 [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
c1afdf9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
e9db1e4 [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
a541ee9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
bb0c77f [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
9142958 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
883d35e [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
b448f36 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
706e1f0 [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
…lvable for some time

Improvements and fixes of apache#863

Author: Igor Skokov <igor.skokov@cinarra.com>
Author: Igor Skokov <lagrang09@gmail.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#1033 from Lagrang/ZOOKEEPER-3320 and squashes the following commits:

50d6465 [Igor Skokov] ZOOKEEPER-3320: doc fix, rename config property 'zookeeper.electionPortBindRetry' to 'electionPortBindRetry'
fb9cdc5 [Igor Skokov] Merge remote-tracking branch 'lagrang/ZOOKEEPER-3320' into ZOOKEEPER-3320
f95ee18 [Igor Skokov] ZOOKEEPER-3320: CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry fix
1af098d [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
7b222ef [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
5051b4c [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
eeb5c41 [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
587fd95 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
0888a29 [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
a9a9342 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
da33c1d [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
e25b445 [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
b4abdc7 [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
c1afdf9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
e9db1e4 [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
a541ee9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
bb0c77f [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
9142958 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
883d35e [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
b448f36 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
706e1f0 [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
…lvable for some time

Improvements and fixes of apache#863

Author: Igor Skokov <igor.skokov@cinarra.com>
Author: Igor Skokov <lagrang09@gmail.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#1033 from Lagrang/ZOOKEEPER-3320 and squashes the following commits:

50d6465 [Igor Skokov] ZOOKEEPER-3320: doc fix, rename config property 'zookeeper.electionPortBindRetry' to 'electionPortBindRetry'
fb9cdc5 [Igor Skokov] Merge remote-tracking branch 'lagrang/ZOOKEEPER-3320' into ZOOKEEPER-3320
f95ee18 [Igor Skokov] ZOOKEEPER-3320: CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry fix
1af098d [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
7b222ef [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
5051b4c [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
eeb5c41 [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
587fd95 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
0888a29 [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
a9a9342 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
da33c1d [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
e25b445 [Igor Skokov] ZOOKEEPER-3320: support custom socket bind error handler in QuorumCnxManager.Listener
b4abdc7 [Igor Skokov] ZOOKEEPER-3320: handle 0 value for zookeeper.electionPortBindRetry as infinite, fix CnxManagerTest. testCnxManagerListenerThreadConfigurableRetry to prevent JVM exit during testing
c1afdf9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
e9db1e4 [Igor Skokov] ZOOKEEPER-3320: fix of test compilation
a541ee9 [Igor Skokov] Merge branch 'master' into ZOOKEEPER-3320
bb0c77f [Igor Skokov] ZOOKEEPER-3320: use existing scheme to stop server when QuorumCnxManager.Listener fails to bind to election port
9142958 [Igor Skokov] ZOOKEEPER-3320: QuorumCnxManager.Listener extends ZookeeperCriticalThread, add test to CnxManagerTest to check configurable retries of leader election port bind
883d35e [Igor Skokov] ZOOKEEPER-3320: add documentation for zookeeper.electionPortBindRetry property
b448f36 [Igor Skokov] ZOOKEEPER-3320: add validation and logging of zookeeper.electionPortBindRetry value
706e1f0 [Igor Skokov] ZOOKEEPER-3320: configurable retry count for election port bind in QuorumCnxManager.Listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants