Skip to content

[ZOOKEEPER-3480] Fix the flaky test in CommitProcessorMetricsTest#1035

Closed
lvfangmin wants to merge 1 commit intoapache:masterfrom
lvfangmin:ZOOKEEPER-3480
Closed

[ZOOKEEPER-3480] Fix the flaky test in CommitProcessorMetricsTest#1035
lvfangmin wants to merge 1 commit intoapache:masterfrom
lvfangmin:ZOOKEEPER-3480

Conversation

@lvfangmin
Copy link
Copy Markdown
Contributor

This test is pretty flaky on Jenkins, the previous code doesn't wait all requests being processed, which may cause flaky.

@maoling
Copy link
Copy Markdown
Member

maoling commented Aug 3, 2019

retest this please

Copy link
Copy Markdown
Member

@maoling maoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@nkalmar
Copy link
Copy Markdown
Contributor

nkalmar commented Aug 5, 2019

retest ant build

Copy link
Copy Markdown
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eolivelli
Copy link
Copy Markdown
Contributor

This is good to go.
Ant build is no more active

@asfgit asfgit closed this in 8fbeec0 Aug 5, 2019
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
This test is pretty flaky on Jenkins, the previous code doesn't wait all requests being processed, which may cause flaky.

Author: Fangmin Lyu <fangmin@apache.org>

Reviewers: Norbert Kalmar <nkalmar@yahoo.com>, maoling <maoling199210191@sina.com>, Michael Han <hanm@apache.org>

Closes apache#1035 from lvfangmin/ZOOKEEPER-3480
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
This test is pretty flaky on Jenkins, the previous code doesn't wait all requests being processed, which may cause flaky.

Author: Fangmin Lyu <fangmin@apache.org>

Reviewers: Norbert Kalmar <nkalmar@yahoo.com>, maoling <maoling199210191@sina.com>, Michael Han <hanm@apache.org>

Closes apache#1035 from lvfangmin/ZOOKEEPER-3480
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
This test is pretty flaky on Jenkins, the previous code doesn't wait all requests being processed, which may cause flaky.

Author: Fangmin Lyu <fangmin@apache.org>

Reviewers: Norbert Kalmar <nkalmar@yahoo.com>, maoling <maoling199210191@sina.com>, Michael Han <hanm@apache.org>

Closes apache#1035 from lvfangmin/ZOOKEEPER-3480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants