Skip to content

Conversation

@cyxpdc
Copy link

@cyxpdc cyxpdc commented Oct 14, 2019

I'm sorry, but I'd like to change the names of these two variables to make them more comfortable.

@cyxpdc
Copy link
Author

cyxpdc commented Oct 14, 2019

and logicalclock,maybe “logicalClock”?

@maoling
Copy link
Member

maoling commented Oct 14, 2019

@cyxpdc

@cyxpdc cyxpdc changed the title "recvset" and "outofelection" I modified it. making some variables in the FastLeaderElection.java conform to the Camel-Case naming standard Oct 14, 2019
@maoling
Copy link
Member

maoling commented Oct 21, 2019

@cyxpdc

  • lots of annotations in this class mention this outofelection, you can use IDE tool to rename all of them
  • Do you have an chance to find all the naming issues in this class:FastLeaderElection to make this patch bigger :)?

@cyxpdc cyxpdc closed this Oct 21, 2019
@cyxpdc
Copy link
Author

cyxpdc commented Oct 21, 2019

@maoling

  • A lot. I'm a little busy recently.,maybe I have time later.I'm sorry.

@cyxpdc cyxpdc reopened this Oct 21, 2019
@anmolnar
Copy link
Contributor

It doesn't seem to be a big deal to me, but happy to commit if you could create a Jira for it.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this change is worth a commit.
And moreover changing variables names can make life harder while porting patches from other branches.

@lvfangmin @hanm

@anmolnar
Copy link
Contributor

And moreover changing variables names can make life harder while porting patches from other branches.

That's a valid concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants