Skip to content

ZOOKEEPER-3057: Fix IPv6 literal usage#1168

Closed
xy24 wants to merge 1 commit intoapache:branch-3.5from
xy24:fix-ipv6-literal
Closed

ZOOKEEPER-3057: Fix IPv6 literal usage#1168
xy24 wants to merge 1 commit intoapache:branch-3.5from
xy24:fix-ipv6-literal

Conversation

@xy24
Copy link
Copy Markdown

@xy24 xy24 commented Dec 9, 2019

This commit backports #548 to branch-3.5.

I cherry picked all the changes except the file (NetUtils.java) where modification were already made by other backports.

@asf-ci
Copy link
Copy Markdown

asf-ci commented Dec 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1697/

@xy24 xy24 mentioned this pull request Dec 9, 2019
Closed
@maoling
Copy link
Copy Markdown
Member

maoling commented Dec 11, 2019

@xy24 Thanks for this work.
I cannot make sure whether it needs to backport to branch3.5. Let's listen to @anmolnar's viewpoint, then we can start the review work.

@xy24
Copy link
Copy Markdown
Author

xy24 commented Dec 11, 2019

@xy24 Thanks for this work.
I cannot make sure whether it needs to backport to branch3.5. Let's listen to @anmolnar's viewpoint, then we can start the review work.

Thanks @maoling.
I personally think this is necessary because IPv6 quorum configurations do not work on the current 3.5.6 release. But let's wait for @anmolnar's viewpoint.

anmolnar
anmolnar approved these changes Dec 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 This is a critical bugfix. Ship it!

@xy24
Copy link
Copy Markdown
Author

xy24 commented Dec 11, 2019

@anmolnar Do I need to do anything to merge it? I see there is a FAILURE in JenkinsAnt but I am not sure how to fix it.

eolivelli
eolivelli approved these changes Dec 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy24
Copy link
Copy Markdown
Author

xy24 commented Dec 17, 2019

@eolivelli How will it get merged? Do I need to do anything?

@eolivelli
Copy link
Copy Markdown
Contributor

eolivelli commented Dec 17, 2019

retest ant build

@eolivelli
Copy link
Copy Markdown
Contributor

eolivelli commented Dec 17, 2019

sorry for late reply.
Let's see a green light for ANT build, then I will be happy to merge.

@anmolnar it would be awesome to include this fix in 3.5.7

@xy24
Copy link
Copy Markdown
Author

xy24 commented Dec 17, 2019

@eolivelli ANT build still failed. Not sure why though.

@eolivelli
Copy link
Copy Markdown
Contributor

eolivelli commented Dec 17, 2019

ANT build is failing with
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

Honestly I don't know what it means.
btw Jenkins job crashed with another error, maybe this is the reason why we can see the report of the 'audit', I am kicking CI again

@eolivelli
Copy link
Copy Markdown
Contributor

eolivelli commented Dec 17, 2019

retest ant build

1 similar comment
@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 17, 2019

retest ant build

@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 17, 2019

Ant build seems to be broken. All tests passed, but build is red.

@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 17, 2019

retest ant build

@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 17, 2019

killed. oh my gosh.

@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 17, 2019

retest ant build

asfgit pushed a commit that referenced this pull request Dec 18, 2019
@xy24 @anmolnar
ZOOKEEPER-3057: Fix IPv6 literal usage
0ec8ffc 
This commit backports #548 to branch-3.5.

I cherry picked all the changes except the file (NetUtils.java) where modification were already made by other backports.

Author: Xiangyu Yao <yaoxiangyu@bytedance.com>

Reviewers: eolivelli@apache.org, andor@apache.org

Closes #1168 from xy24/fix-ipv6-literal
@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Dec 18, 2019

Merged. Thanks @xy24 !

@anmolnar anmolnar closed this Dec 18, 2019
@xy24
Copy link
Copy Markdown
Author

xy24 commented Dec 18, 2019

Thanks @anmolnar @eolivelli @maoling !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmolnar anmolnar anmolnar approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xy24 @asf-ci @maoling @eolivelli @anmolnar