ZOOKEEPER-3675: Clean Up committedLog Interaction in ZKDatabase #1202
+16
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztzg
approved these changes
Jan 8, 2020
| p.packet = pp; | ||
| p.request = request; | ||
|
|
||
| if (committedLog.size() == commitLogCount) { |
Contributor
There was a problem hiding this comment.
Interesting. I was initially puzzled by the change from > to ==. This also fixes an off-by-one error in the existing code (and, consequently, makes the log one entry shorter), doesn't it? I'd probably add a bullet point saying so to the description.
Contributor
Author
There was a problem hiding this comment.
@ztzg Lol. I actually didn't even realize I fixed that, but you're correct. I'll update the docs.
Contributor
Author
|
@anmolnar Are you able to take a peek at this one too? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.