Zookeeper-3718: The tarball generated by assembly is missing some files#1250
Closed
nkalmar wants to merge 1 commit intoapache:branch-3.5from
Closed
Zookeeper-3718: The tarball generated by assembly is missing some files#1250nkalmar wants to merge 1 commit intoapache:branch-3.5from
nkalmar wants to merge 1 commit intoapache:branch-3.5from
Conversation
eolivelli
approved these changes
Feb 9, 2020
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I can't merge now. Feel free to move forward and merge and cherry pick by yourself
asfgit
pushed a commit
that referenced
this pull request
Feb 10, 2020
There were missing files from the generated source tarball, namely: -checkstyleSuppressions.xml, .travis.yml and "dev" directory missing -the generated jute was included with the C client code Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes #1250 from nkalmar/ZOOKEEPER-3718
asfgit
pushed a commit
that referenced
this pull request
Feb 10, 2020
There were missing files from the generated source tarball, namely: -checkstyleSuppressions.xml, .travis.yml and "dev" directory missing -the generated jute was included with the C client code Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes #1250 from nkalmar/ZOOKEEPER-3718 (cherry picked from commit 2424010) Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
Contributor
Author
|
Merged to 3.5 and 3.5.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were missing files from the generated source tarball, namely:
-checkstyleSuppressions.xml, .travis.yml and "dev" directory missing
-the generated jute was included with the C client code