Zookeeper-3581: Use factory design pattern to refactor ZooKeeperMain#1255
Closed
jonomorris wants to merge 5 commits intoapache:masterfrom
Closed
Zookeeper-3581: Use factory design pattern to refactor ZooKeeperMain#1255jonomorris wants to merge 5 commits intoapache:masterfrom
jonomorris wants to merge 5 commits intoapache:masterfrom
Conversation
2. Add unit tests for CommandFactory. 3. Remove redundant import from CommandFactory.
jonomorris
changed the title
jonomorris
changed the title
Contributor
|
@jono-morris Committed to master branch, thanks. |
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant. Author: Jono <jono.morris@xtra.co.nz> Reviewers: andor@apache.org Closes apache#1255 from jono-morris/ZOOKEEPER-3581 and squashes the following commits: 556e176 [Jono] Fix style errors with import statements. e10dfb8 [Jono] Add licence text. 4957d89 [Jono] 1. Reinstate missing imports to ZooKeeperMain. ed76f14 [Jono] Minor Javadoc updates. cc8de49 [Jono] Add Factory to create CliCommand classes. Initial Commit.
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant. Author: Jono <jono.morris@xtra.co.nz> Reviewers: andor@apache.org Closes apache#1255 from jono-morris/ZOOKEEPER-3581 and squashes the following commits: 556e176 [Jono] Fix style errors with import statements. e10dfb8 [Jono] Add licence text. 4957d89 [Jono] 1. Reinstate missing imports to ZooKeeperMain. ed76f14 [Jono] Minor Javadoc updates. cc8de49 [Jono] Add Factory to create CliCommand classes. Initial Commit.
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant. Author: Jono <jono.morris@xtra.co.nz> Reviewers: andor@apache.org Closes apache#1255 from jono-morris/ZOOKEEPER-3581 and squashes the following commits: 556e176 [Jono] Fix style errors with import statements. e10dfb8 [Jono] Add licence text. 4957d89 [Jono] 1. Reinstate missing imports to ZooKeeperMain. ed76f14 [Jono] Minor Javadoc updates. cc8de49 [Jono] Add Factory to create CliCommand classes. Initial Commit.
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant. Author: Jono <jono.morris@xtra.co.nz> Reviewers: andor@apache.org Closes apache#1255 from jono-morris/ZOOKEEPER-3581 and squashes the following commits: 556e176 [Jono] Fix style errors with import statements. e10dfb8 [Jono] Add licence text. 4957d89 [Jono] 1. Reinstate missing imports to ZooKeeperMain. ed76f14 [Jono] Minor Javadoc updates. cc8de49 [Jono] Add Factory to create CliCommand classes. Initial Commit.
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant. Author: Jono <jono.morris@xtra.co.nz> Reviewers: andor@apache.org Closes apache#1255 from jono-morris/ZOOKEEPER-3581 and squashes the following commits: 556e176 [Jono] Fix style errors with import statements. e10dfb8 [Jono] Add licence text. 4957d89 [Jono] 1. Reinstate missing imports to ZooKeeperMain. ed76f14 [Jono] Minor Javadoc updates. cc8de49 [Jono] Add Factory to create CliCommand classes. Initial Commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a factory design pattern to refactor ZooKeeperMain, making the code more elegant.