Zookeeper 3604 Added documentation for Path variable#1264
Zookeeper 3604 Added documentation for Path variable#1264asutosh936 wants to merge 2 commits intoapache:masterfrom asutosh936:ZOOKEEPER-3604
Conversation
|
@eolivelli Do you want to merge it: ) ? |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I am sorry.
This patch is not worth a commit.
I appreciate the intent but it would be better to create a bigger path, for instance a patch that fixes all of this cases (empty parameters description javadoc in the whole file)
|
@eolivelli - Make sense, will update PR with rest of the missing |
|
@eolivelli - Have updated documentation for all |
|
Team, any update on this PR? |
|
@eolivelli - Could You please review and merge this PR? |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Hi.
I feel this patch still is not worth to be committed.
If we want to fix javadoc we should do it in a consistent way and have a plan.
What real value is added by this patch?
I am sorry I don't want to be annoying and I appreciate your efforts
It would be better to start a plan to fix javadoc and make them required someway.
This is not trivial because it is difficult to draw a line and decide what is important and what is boilerplate.
Maybe I am wrong.
This patch is open, if any other commiter wants to sponsor it I am not against it.
I am +0
3 participants
No description provided.