ZOOKEEPER-4218:zooKeeperSaslClient will product a null state event and then caused NPE while used switch(state) to deal with event #1646
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d then caused NPE while used switch(state) to deal with event.
maoling
reviewed
Mar 26, 2021
| saslState = SaslState.FAILED; | ||
| throw new SaslException("Failed to send SASL packet to server due " + "to IOException:", e); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
@smallYellowCat
Could you please add an unit case for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while excute zooKeeperSaslClient.initialize(ClientCnxn.this) occurred some exception, at time saslState is SaslState.INITIAL, and then sendAuthEvent will be set true, but KeeperState authState = zooKeeperSaslClient.getKeeperState() will return null authState, so client will create a null state event.