Skip to content

[ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded#1736

Closed
cuibo01 wants to merge 2 commits intoapache:masterfrom
cuibo01:zookeeper-4345
Closed

[ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded#1736
cuibo01 wants to merge 2 commits intoapache:masterfrom
cuibo01:zookeeper-4345

Conversation

@cuibo01
Copy link
Copy Markdown
Contributor

@cuibo01 cuibo01 commented Aug 7, 2021

No description provided.

@cuibo01
Copy link
Copy Markdown
Contributor Author

cuibo01 commented Aug 7, 2021

@ztzg @nkalmar @maoling @eolivelli pls review, thx

eolivelli
eolivelli requested changes Aug 7, 2021
View reviewed changes
Comment thread zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java Outdated
@cuibo01
Copy link
Copy Markdown
Contributor Author

cuibo01 commented Aug 8, 2021 •
edited
Loading

@eolivelli How to Rerun Failed CI. in my pc, all UTs are ok

@cuibo01 cuibo01 closed this Aug 8, 2021
@cuibo01 cuibo01 reopened this Aug 8, 2021
@cuibo01 cuibo01 closed this Aug 9, 2021
@cuibo01 cuibo01 reopened this Aug 9, 2021
eolivelli
eolivelli requested changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand better the goal.

In this case we can add some testcase about using only the classname (without package).

@cuibo01
Copy link
Copy Markdown
Contributor Author

cuibo01 commented Aug 9, 2021

Now I understand better the goal.

In this case we can add some testcase about using only the classname (without package).

thx for your review， i will add UT asap

eolivelli
eolivelli requested changes Aug 10, 2021
View reviewed changes
Comment thread zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java
eolivelli
eolivelli approved these changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we need another review to sponsor this patch

tagging @maoling @ztzg @anmolnar @phunt @nkalmar @symat

Comment thread zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java
@eolivelli
Copy link
Copy Markdown
Contributor

eolivelli commented Aug 10, 2021

thank you @arshadmohammad
do you want to merge this patch ?
we can cherry pick to 3.7.x and probably also to 3.6.x

@asfgit asfgit closed this in 5f6ec6c Aug 11, 2021
asfgit pushed a commit that referenced this pull request Aug 11, 2021
@cuibo01 @arshadmohammad
ZOOKEEPER-4345: Avoid NoSunchMethodException caused by shaded zookeep…
434c54d 
…er jar

Author: Bo <cuibo0108@163.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes #1736 from cuibo01/zookeeper-4345 and squashes the following commits:

3965f2e [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
9709729 [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded

(cherry picked from commit 5f6ec6c)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
asfgit pushed a commit that referenced this pull request Aug 11, 2021
@cuibo01 @arshadmohammad
ZOOKEEPER-4345: Avoid NoSunchMethodException caused by shaded zookeep…
f658cdc 
…er jar

Author: Bo <cuibo0108@163.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes #1736 from cuibo01/zookeeper-4345 and squashes the following commits:

3965f2e [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
9709729 [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
@arshadmohammad
Copy link
Copy Markdown
Contributor

arshadmohammad commented Aug 11, 2021

Merged to master, branch-3.7 and branch-3.6.
Thanks @cuibo01 for the contribution.
Thanks @eolivelli for the reviews.

@cuibo01 cuibo01 deleted the zookeeper-4345 branch August 31, 2021 06:30
asfgit pushed a commit that referenced this pull request May 17, 2022
@cuibo01
ZOOKEEPER-4345: Avoid NoSunchMethodException caused by shaded zookeep…
65615a5 
…er jar

Author: Bo <cuibo0108@163.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes #1736 from cuibo01/zookeeper-4345 and squashes the following commits:

3965f2e [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
9709729 [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded

(cherry picked from commit f658cdc)
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 17, 2023
@cuibo01 @desaikomal
ZOOKEEPER-4345: Avoid NoSunchMethodException caused by shaded zookeep…
1f75800 
…er jar

Author: Bo <cuibo0108@163.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes apache#1736 from cuibo01/zookeeper-4345 and squashes the following commits:

3965f2e [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
9709729 [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 27, 2023
@cuibo01 @desaikomal
ZOOKEEPER-4345: Avoid NoSunchMethodException caused by shaded zookeep…
aba3daa 
…er jar

Author: Bo <cuibo0108@163.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>

Closes apache#1736 from cuibo01/zookeeper-4345 and squashes the following commits:

3965f2e [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
9709729 [Bo] [ZOOKEEPER-4345]Avoid NoSunchMethodException caused by shaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadmohammad arshadmohammad arshadmohammad approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cuibo01 @eolivelli @arshadmohammad