ZOOKEEPER-4381: Remove magic string in QuorumPeerConfig #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_patch4381
branch
3 times, most recently
from
9899a02 to
cb9e7a5
Compare
maoling
reviewed
Oct 20, 2021
| */ | ||
| public static void writeDynamicConfig(final String dynamicConfigFilename, final QuorumVerifier qv, final boolean needKeepVersion) throws IOException { | ||
| public static void writeDynamicConfig(final String dynamicConfigFilename, final QuorumVerifier qv, | ||
| final boolean needKeepVersion) throws IOException { |
Member
There was a problem hiding this comment.
Great refactor. There're some uncorrelated changes(most are line break). Please revert them.
Member
Author
There was a problem hiding this comment.
Thanks for your review, I have reverted the uncorrelated changes, I am not sure if this will make the code style check failed.
ruanwenjun
force-pushed
the
dev_wenjun_patch4381
branch
from
a04f7e9 to
dc6deea
Compare
eolivelli
requested changes
Jan 17, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I left some nits, overall the patch is good, thanks
| } | ||
| } | ||
|
|
||
| private int parseInt(String key, String value) throws ConfigException { |
Member
Author
There was a problem hiding this comment.
Done, but I am little confused why we need to change this method to static? Right now, this is not used in a static method. Maybe for future?
| private int parseInt(String key, String value) throws ConfigException { | ||
| try { | ||
| return Integer.parseInt(value); | ||
| } catch (Exception ex) { |
| private long parseLong(String key, String value) throws ConfigException { | ||
| try { | ||
| return Long.parseLong(value); | ||
| } catch (Exception ex) { |
ruanwenjun
force-pushed
the
dev_wenjun_patch4381
branch
from
dc6deea to
4bd0894
Compare
ruanwenjun
force-pushed
the
dev_wenjun_patch4381
branch
from
4bd0894 to
35659fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.