Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2737: close netty connection when exceptions occur during w… #207

Closed
wants to merge 1 commit into from

Conversation

@hanm
Copy link
Contributor

hanm commented Mar 24, 2017

…rite to channel to prevent resource leak.

I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases..

…rite to channel.

To prevent resource leak.
@enixon

This comment has been minimized.

Copy link

enixon commented Mar 24, 2017

good catch!

@afine

This comment has been minimized.

Copy link
Contributor

afine commented Mar 27, 2017

+1

@phunt

This comment has been minimized.

Copy link
Contributor

phunt commented Mar 27, 2017

Ugh, sorry about that. ;-)

+1

@rakeshadr

This comment has been minimized.

Copy link
Contributor

rakeshadr commented Mar 27, 2017

Thanks @hanm, +1 LGTM

asfgit pushed a commit that referenced this pull request Mar 27, 2017
…rite to channel to prevent resource leak.

I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases..

Author: Michael Han <hanm@apache.org>

Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org>

Closes #207 from hanm/ZOOKEEPER-2737
@asfgit asfgit closed this in d8adc54 Mar 27, 2017
asfgit pushed a commit that referenced this pull request Jul 20, 2017
…rite to channel to prevent resource leak.

This bug happily hides in code base for 7 years until it's revealed from a failed unit tests. This commit is cherry picked from ZOOKEEPER-2737 / 5c356f5.

Author: Michael Han <hanm@apache.org>

Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org>

Closes #207 from hanm/ZOOKEEPER-2737
lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018
…rite to channel to prevent resource leak.

I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases..

Author: Michael Han <hanm@apache.org>

Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org>

Closes apache#207 from hanm/ZOOKEEPER-2737

(cherry picked from commit 5c356f5)
Signed-off-by: Michael Han <hanm@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.