ZOOKEEPER-2737: close netty connection when exceptions occur during w…#207
Closed
hanm wants to merge 1 commit intoapache:branch-3.5from
Closed
ZOOKEEPER-2737: close netty connection when exceptions occur during w…#207hanm wants to merge 1 commit intoapache:branch-3.5from
hanm wants to merge 1 commit intoapache:branch-3.5from
Conversation
…rite to channel. To prevent resource leak.
|
good catch! |
Contributor
|
+1 |
Contributor
|
Ugh, sorry about that. ;-) +1 |
Contributor
|
Thanks @hanm, +1 LGTM |
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2017
…rite to channel to prevent resource leak. I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases.. Author: Michael Han <hanm@apache.org> Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org> Closes #207 from hanm/ZOOKEEPER-2737
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2017
…rite to channel to prevent resource leak. This bug happily hides in code base for 7 years until it's revealed from a failed unit tests. This commit is cherry picked from ZOOKEEPER-2737 / 5c356f5. Author: Michael Han <hanm@apache.org> Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org> Closes #207 from hanm/ZOOKEEPER-2737
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
…rite to channel to prevent resource leak. I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases.. Author: Michael Han <hanm@apache.org> Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org> Closes apache#207 from hanm/ZOOKEEPER-2737 (cherry picked from commit 5c356f5) Signed-off-by: Michael Han <hanm@apache.org>
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…rite to channel to prevent resource leak. I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases.. Author: Michael Han <hanm@apache.org> Reviewers: Brian Nixon <nixon@fb.com>, Abraham Fine <afine@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org>, Patrick Hunt <phunt@apache.org> Closes apache#207 from hanm/ZOOKEEPER-2737 (cherry picked from commit 5c356f5) Signed-off-by: Michael Han <hanm@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rite to channel to prevent resource leak.
I am OK to add some contrived test case to test this but I'd like to do that later if needed, so this fix can get in upcoming releases..