Closed
Conversation
Contributor
|
+1 looks like this typo also exists in branch-3.4 and branch-3.5 |
Contributor
|
@jeffwidman could you please open a jira to track this change: https://issues.apache.org/jira/ |
Contributor
|
+1 to what @afine wrote. Plus, target your PR to branch-3.4 and then we can cherry-pick it into branch-3.5 and master after applying it to branch-3.4 |
Contributor
Author
|
Closing in favor of #228 as I didn't realize github's UI now supported changing the target branch. Oh well. |
Closed
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Continued from apache#210 and targeting the 3.4 branch as requested. Author: Jeff Widman <jeff@jeffwidman.com> Reviewers: Michael Han <hanm@apache.org> Closes apache#228 from jeffwidman/patch-2 (cherry picked from commit 04b7553) Signed-off-by: Michael Han <hanm@apache.org>
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Continued from apache#210 and targeting the 3.4 branch as requested. Author: Jeff Widman <jeff@jeffwidman.com> Reviewers: Michael Han <hanm@apache.org> Closes apache#228 from jeffwidman/patch-2 (cherry picked from commit 04b7553) Signed-off-by: Michael Han <hanm@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.